----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105120/#review14349 -----------------------------------------------------------
Ship it! Good job! Please post single cumulative commit. kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/105120/#comment11333> style note: please use space inside of '){' - happened in other places too kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/105120/#comment11334> style note: please no space within ( ) - happened in other places too kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/105120/#comment11335> the same... kexi/plugins/forms/kexiformmanager.cpp <http://git.reviewboard.kde.org/r/105120/#comment11336> please move the three new widget to the very end because these are less requently used; unless we have toolbox, this is all we can do to keep usability at acceptable level kexi/plugins/forms/widgets/kexidbprogressbar.h <http://git.reviewboard.kde.org/r/105120/#comment11337> let's no longer use bit fields: no practical benefits kexi/plugins/forms/widgets/kexidbprogressbar.cpp <http://git.reviewboard.kde.org/r/105120/#comment11338> : QProgressBar(parent), KexiFormDataItemInterface() kexi/plugins/forms/widgets/kexidbprogressbar.cpp <http://git.reviewboard.kde.org/r/105120/#comment11339> the progressbar is by definition read-only so this method should stay empty (?) kexi/plugins/forms/widgets/kexidbslider.cpp <http://git.reviewboard.kde.org/r/105120/#comment11340> ok - Jarosław Staniek On May 31, 2012, 4:55 p.m., Oleg Kukharchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105120/ > ----------------------------------------------------------- > > (Updated May 31, 2012, 4:55 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Description > ------- > > Implemented widgets: > KexiDBCommandLinkButton > KexiDBSlider > KexiDBProgressBar > > > Diffs > ----- > > kexi/formeditor/kexiformeventhandler.cpp > dbfcd6679a3d1db65a76e6f57dd1b43aa89015d7 > kexi/kexiutils/KexiCommandLinkButton.h > 210681a449103f1ece135715a8d9fbb9005848ee > kexi/plugins/forms/CMakeLists.txt 3d9f268ee9f4cbb04c590330aad6d53aa28a8421 > kexi/plugins/forms/kexidbfactory.cpp > 8f53bf98041acff951858f46d45bbd52120f4f6a > kexi/plugins/forms/kexiformmanager.cpp > 9b202fcb8ff5f8e39e0122ebe78074fbe1ff1bfb > kexi/plugins/forms/kexiformpartinstui.rc > 75f233f24dae812a9f4dc4344dd89b92197b86c0 > kexi/plugins/forms/kexiformview.cpp > b814c63b8ec47c3ccc155137670325eff439cd46 > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.h PRE-CREATION > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp PRE-CREATION > kexi/plugins/forms/widgets/kexidbprogressbar.h PRE-CREATION > kexi/plugins/forms/widgets/kexidbprogressbar.cpp PRE-CREATION > kexi/plugins/forms/widgets/kexidbslider.h PRE-CREATION > kexi/plugins/forms/widgets/kexidbslider.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105120/diff/ > > > Testing > ------- > > > Thanks, > > Oleg Kukharchuk > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
