----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105094/#review14261 -----------------------------------------------------------
Very good quality code as for the first contribution! Please remove the inherited from stdwidgetfactory for a reason explained below. Reminder: please do not work on master branch nor commit there, instead create your own branch and commit there - we will squash commits into one when will be ready. kexi/formeditor/factories/stdwidgetfactory.cpp <http://git.reviewboard.kde.org/r/105094/#comment11287> I would say: please only define the widget in plugins/forms/kexidbfactory.cpp, all factories will be merged there anyway. stdwidgefactory used to be independent of Kexi and this is why it keeps simple widgets for kexidbfactory inheritance we do not need this independency. kexi/formeditor/factories/stdwidgetfactory.cpp <http://git.reviewboard.kde.org/r/105094/#comment11286> No need to have lines like "added by" as we have git history... kexi/formeditor/factories/stdwidgetfactory.cpp <http://git.reviewboard.kde.org/r/105094/#comment11288> I propose shorter: "Link Button" kexi/formeditor/factories/stdwidgetfactory.cpp <http://git.reviewboard.kde.org/r/105094/#comment11289> I propose shorter "linkButton" kexi/formeditor/factories/stdwidgetfactory.cpp <http://git.reviewboard.kde.org/r/105094/#comment11290> (Like in Qt Designer) please let's do not set description by default, it will be faster to use. kexi/plugins/forms/kexidbfactory.cpp <http://git.reviewboard.kde.org/r/105094/#comment11291> no need for inheritance here, as said above - Jarosław Staniek On May 28, 2012, 8:35 p.m., Oleg Kukharchuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105094/ > ----------------------------------------------------------- > > (Updated May 28, 2012, 8:35 p.m.) > > > Review request for Calligra and Jarosław Staniek. > > > Description > ------- > > KexiDBCommandLinkButton Implementation > > > Diffs > ----- > > kexi/formeditor/factories/CMakeLists.txt > d06a3aff146f1704745eda167b51539c315889cf > kexi/formeditor/factories/stdwidgetfactory.cpp > ff4f451608176d955e5f7d46b3dde0c5380d9ad4 > kexi/formeditor/kexiformeventhandler.cpp > dbfcd6679a3d1db65a76e6f57dd1b43aa89015d7 > kexi/kexiutils/KexiCommandLinkButton.h > 210681a449103f1ece135715a8d9fbb9005848ee > kexi/plugins/forms/CMakeLists.txt 3d9f268ee9f4cbb04c590330aad6d53aa28a8421 > kexi/plugins/forms/kexidbfactory.cpp > 8f53bf98041acff951858f46d45bbd52120f4f6a > kexi/plugins/forms/kexiformmanager.cpp > 9b202fcb8ff5f8e39e0122ebe78074fbe1ff1bfb > kexi/plugins/forms/kexiformpartinstui.rc > 75f233f24dae812a9f4dc4344dd89b92197b86c0 > kexi/plugins/forms/kexiformview.cpp > b814c63b8ec47c3ccc155137670325eff439cd46 > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.h PRE-CREATION > kexi/plugins/forms/widgets/kexidbcommandlinkbutton.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/105094/diff/ > > > Testing > ------- > > > Thanks, > > Oleg Kukharchuk > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
