> On May 22, 2012, 9:04 a.m., Boudewijn Rempt wrote: > > sheets/CMakeLists.txt, line 332 > > <http://git.reviewboard.kde.org/r/105010/diff/1/?file=65123#file65123line332> > > > > er, why this?
You need a <appname>.notifyrc if you actually want KNotification to issue a notification, sending a dbus message is not enough. Only Sheets have this file, no other app, so I propose to remove it for Sheets also for consistency. - Dag ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105010/#review14031 ----------------------------------------------------------- On May 22, 2012, 9:02 a.m., Dag Andersen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105010/ > ----------------------------------------------------------- > > (Updated May 22, 2012, 9:02 a.m.) > > > Review request for Calligra. > > > Description > ------- > > AFAICS any calligra app potentially crashes during query close. > The reason is a notification issued in KoDocument::saveFile() which results > in an async dbus message. > The reply to this message can be received (timing dependent) during deletion > of the dbus conection in which case it will crash. > > I propose to just remove the notification as I cannot see a use case for it > (unless saving a file takes a looong time) > Also it is only activated in Sheets (where it is still called KSpread, btw), > no other app uses it. > > So the patch removes the notification from KoDocument::saveFile() and removes > the sheets.notifyrc file from sheets. > > > This addresses bug 297822. > http://bugs.kde.org/show_bug.cgi?id=297822 > > > Diffs > ----- > > libs/main/KoDocument.cpp 03086b3 > sheets/CMakeLists.txt 5355719 > > Diff: http://git.reviewboard.kde.org/r/105010/diff/ > > > Testing > ------- > > Well, hard to test, but I found that running plan under gdb triggered the > crash most of the time (ymmv). > With patch applied I have not seen a crash yet. > > > Thanks, > > Dag Andersen > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
