> On May 20, 2012, 6:33 a.m., Boudewijn Rempt wrote: > > krita/ui/kra/kis_kra_saver.cpp, line 172 > > <http://git.reviewboard.kde.org/r/104993/diff/1/?file=65003#file65003line172> > > > > I'm not sure you need the if (assist->id() == "bla") here -- wouldn't > > it be more efficient use the id in the name, and have a map of id to count, > > instead of separate count variables? > > > > Something like: > > > > QMap<QString, int> assistantcounters; > > > > assistantcounter[assist->id())++; > > > > location += assistent->id() + assistantcounter[assist->id()) + > > ".assistant);
The if condition will have to be the same, although the counters can be put in a map and the location created using them. - Shivaraman ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104993/#review13992 ----------------------------------------------------------- On May 19, 2012, 10:27 a.m., Shivaraman Aiyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104993/ > ----------------------------------------------------------- > > (Updated May 19, 2012, 10:27 a.m.) > > > Review request for Calligra. > > > Description > ------- > > The Painting Assistants in Krita did not have the feature to be saved. This > patch fixes that problem and lets the Assistants be saved and loaded for > future use. > > > Diffs > ----- > > krita/plugins/assistants/RulerAssistant/EllipseAssistant.h f6fd83b > krita/plugins/assistants/RulerAssistant/EllipseAssistant.cc 45851f1 > krita/plugins/assistants/RulerAssistant/PerspectiveAssistant.h c064d0b > krita/plugins/assistants/RulerAssistant/PerspectiveAssistant.cc bd313a7 > krita/plugins/assistants/RulerAssistant/RulerAssistant.h 2dd0307 > krita/plugins/assistants/RulerAssistant/RulerAssistant.cc 4357a2b > krita/plugins/assistants/RulerAssistant/SplineAssistant.h 76fdfe4 > krita/plugins/assistants/RulerAssistant/SplineAssistant.cc 7a1a2bb > krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc f189346 > krita/ui/kis_doc2.h ef0413b > krita/ui/kis_doc2.cc 01752c1 > krita/ui/kis_painting_assistant.h 34757b4 > krita/ui/kis_painting_assistant.cc a42beb9 > krita/ui/kis_painting_assistants_manager.cc b030aa2 > krita/ui/kis_view2.cpp e8e81af > krita/ui/kra/kis_kra_loader.h 328149d > krita/ui/kra/kis_kra_loader.cpp d14a7d5 > krita/ui/kra/kis_kra_saver.h d114c2a > krita/ui/kra/kis_kra_saver.cpp 75b336e > krita/ui/kra/kis_kra_tags.h da81174 > > Diff: http://git.reviewboard.kde.org/r/104993/diff/ > > > Testing > ------- > > A basic testing of the assistants has been done after they are loaded. > > > Thanks, > > Shivaraman Aiyer > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
