----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104980/#review13946 -----------------------------------------------------------
Ship it! Looks good. I bet there are many places that could use these new functions. - Inge Wallin On May 18, 2012, 5:50 a.m., Thorsten Zachmann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104980/ > ----------------------------------------------------------- > > (Updated May 18, 2012, 5:50 a.m.) > > > Review request for Calligra. > > > Description > ------- > > Fix saving of precentage values in gradient styles. > > When saving the file odf/odp/114096.odp from calligratests invalid xml is > generated: > > [11:37:25]: [odf/odp/114096.odp] INVALIDSTYLESXML: (unknown file):62: error: > value of attribute "svg:x2" is invalid; must be a string matching the regular > expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)%" or must be a string matching the > regular expression > "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)((cm)|(mm)|(in)|(pt)|(pc)|(px))" (unknown > file):62: error: value of attribute "svg:y1" is invalid; must be a string > matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)%" or must be > a string matching the regular expression > "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)((cm)|(mm)|(in)|(pt)|(pc)|(px))" (unknown > file):65: error: value of attribute "svg:x2" is invalid; must be a string > matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)%" or must be > a string matching the regular expression > "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)((cm)|(mm)|(in)|(pt)|(pc)|(px))" (unknown > file):65: error: value of attribute "svg:y1" is invalid; must be a string > matching the regular expression "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)%" or must be > a string matching the regular expression > "-?([0-9]+(\.[0-9]*)?|\.[0-9]+)((cm)|(mm)|(in)|(pt)|(pc)|(px))" > > The problem is that the gradient attributes are saved like: > > <svg:linearGradient draw:name="gradient3" svg:spreadMethod="pad" > svg:x1="100%" svg:x2="-6.66134e-14%" svg:y1="5.55112e-14%" svg:y2="100%"> > <svg:stop svg:offset="0" svg:stop-color="#cc3300"/> > <svg:stop svg:offset="1" svg:stop-color="#c7a309"/> > </svg:linearGradient> > > however e-14 is not alloed in the value for precent. > > This patch adds a new function to add percent attributes that takes care of > using the correct format. > > > Diffs > ----- > > libs/odf/KoGenStyle.h 8c469d6 > libs/odf/KoGenStyle.cpp b3ac9d8 > libs/odf/KoOdfGraphicStyles.cpp 0776848 > > Diff: http://git.reviewboard.kde.org/r/104980/diff/ > > > Testing > ------- > > Tested with the 114096 and the above error is gone. > > > Thanks, > > Thorsten Zachmann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
