-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104928/#review13875
-----------------------------------------------------------
The resizing of the canvas works now partly.
o When resizing the canvas flickers quite a lot, more then I think it should.
The canvas is not going only in one direction but it is is jumping back and
forth
This seems to get fixed if I remove the following code
if (!forceUpdate) {
// if due to shape movement we change the scroll bar so the page
itself
// doesn't move
d->canvasController->setScrollBarValue(scrollValue - scrollChange);
}
Maybe this code should only be executed when the scrollbar gets visible or
is hidden?
o The canvas size is not always updated.
The reproduced:
- move an object to the right out of the page.
- unselect the object
- undo the change.
-> canvas should resize, but does not.
- Thorsten Zachmann
On May 15, 2012, 8:59 a.m., C. Boemann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104928/
> -----------------------------------------------------------
>
> (Updated May 15, 2012, 8:59 a.m.)
>
>
> Review request for Calligra.
>
>
> Description
> -------
>
> KoPageApp applications Stage and Flow used to have extra space reserved
> around the page/slide so objects could be put there. However that made it
> really hard for the user to work with.
>
> This patch changes that so there si no space around the page/slide. But..
> instead you can drag objects outside the page/slide without any limit at all
>
>
> Diffs
> -----
>
> libs/kopageapp/KoPACanvas.cpp 4a4748c
> libs/kopageapp/KoPAView.h 01fbdf1
> libs/kopageapp/KoPAView.cpp 4d13dfa
> libs/kopageapp/KoPAViewModeNormal.cpp d5aa5f6
> libs/widgets/KoZoomController.h 4f4c6a2
> libs/widgets/KoZoomController.cpp e10c5b4
> stage/part/KPrViewModeNotes.h b707770
> stage/part/KPrViewModeNotes.cpp c951ade
>
> Diff: http://git.reviewboard.kde.org/r/104928/diff/
>
>
> Testing
> -------
>
> I've tested zooming in and out in Stage normal, notes, and sorter viewmodes,
> and in Flow.
>
> I've tested that running presentations still work, however I've not tested
> presenterview.
>
> I've tested moving shapes outside the page/slide in both Stage and Flow.
>
>
> Thanks,
>
> C. Boemann
>
>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
