----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104892/#review13607 -----------------------------------------------------------
It looks very good. Big big thanks for doing this. Only hada few issues, and havn't tested it myself. I would support anyone else pressing ship-it and i'll press ship-it myself once everybody has had a chance to yell stop libs/main/KoApplication.cpp <http://git.reviewboard.kde.org/r/104892/#comment10797> space And wouldn't using.contains here instead of looping be nicer libs/main/KoAutoSaveRecoveryDialog.cpp <http://git.reviewboard.kde.org/r/104892/#comment10798> space - C. Boemann On May 9, 2012, 2:55 p.m., Boudewijn Rempt wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104892/ > ----------------------------------------------------------- > > (Updated May 9, 2012, 2:55 p.m.) > > > Review request for Calligra. > > > Description > ------- > > 1) X-KDE-NativeExtension can be empy, in that case take mime->mainExtension. > > Otherwise our autosave files are called .autosave, and that's not > something > the filter's mime detection can handle > > 2) don't overwrite autosave files when running multiple unnamed modified > documents > > 3) tag the autosave files with the pid and use dbus to check which processes > that have autosave files are still active; don't offer to recover those. > > 4) show the autosave files in a nice dialog with the ora/odf thumbnail > as a preview, and offer to recover them all. > > > This addresses bug 299611. > http://bugs.kde.org/show_bug.cgi?id=299611 > > > Diffs > ----- > > libs/main/KoMainWindow.cpp c01f44d > libs/main/KoAutoSaveRecoveryDialog.cpp PRE-CREATION > libs/main/KoDocument.h 0a28c7c > libs/main/KoDocument.cpp d2d3938 > libs/main/KoAutoSaveRecoveryDialog.h PRE-CREATION > libs/main/CMakeLists.txt ea408b7 > libs/main/KoApplication.cpp 12ddec3 > > Diff: http://git.reviewboard.kde.org/r/104892/diff/ > > > Testing > ------- > > went manually through all possible scenarios > > > Screenshots > ----------- > > autosavefile recovery dialog > http://git.reviewboard.kde.org/r/104892/s/561/ > > > Thanks, > > Boudewijn Rempt > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
