----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104813/#review13228 -----------------------------------------------------------
As written in the comments the functionality should be moved to KoTosContainer as that is the place handling text on shape. libs/flake/KoShape.h <http://git.reviewboard.kde.org/r/104813/#comment10351> These functions and the members used for this don't belong into KoShape. These methods and members should be in KoTosContainer. plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <http://git.reviewboard.kde.org/r/104813/#comment10352> This should go into KoTosContainer::loadText so it is used for all shapes supporting text on shape. - Thorsten Zachmann On May 1, 2012, 4:55 p.m., Gopalakrishna Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104813/ > ----------------------------------------------------------- > > (Updated May 1, 2012, 4:55 p.m.) > > > Review request for Calligra. > > > Description > ------- > > We used to ignore the vertical and horizontal alignment for Enhanced path > shape. This patch fixes that issue. > > > This addresses bug 284260. > http://bugs.kde.org/show_bug.cgi?id=284260 > > > Diffs > ----- > > libs/flake/KoShape.h 276c957 > libs/flake/KoShape.cpp 1789484 > libs/flake/KoShape_p.h a8ef367 > plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp dc29c3a > > Diff: http://git.reviewboard.kde.org/r/104813/diff/ > > > Testing > ------- > > Loaded the document in the bug report and checked > > > Thanks, > > Gopalakrishna Bhat > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
