> On April 30, 2012, 5:11 p.m., C. Boemann wrote: > >
Zagge has a different way to fix the issue that he has pushed > On April 30, 2012, 5:11 p.m., C. Boemann wrote: > > libs/kotext/styles/KoListLevelProperties.cpp, line 854 > > <http://git.reviewboard.kde.org/r/104795/diff/1/?file=59654#file59654line854> > > > > just curious: what is the reason for this move. We should save > > attributes in the order specified in schema. Not sure we did that before > > either. The move is done because before fo:width was added as innerText to style:list-level-properties and not as a attribute since the element has text:list-level-position-and-space-mode as a child. > On April 30, 2012, 5:11 p.m., C. Boemann wrote: > > libs/flake/KoShapeSavingContext.cpp, line 78 > > <http://git.reviewboard.kde.org/r/104795/diff/1/?file=59652#file59652line78> > > > > this looks wrong, there should only be one image collection per > > document, and here you are creating a private one? I did not know that the design was that we have only one image collection per document - Gopalakrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104795/#review13146 ----------------------------------------------------------- On April 30, 2012, 3:06 p.m., Gopalakrishna Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104795/ > ----------------------------------------------------------- > > (Updated April 30, 2012, 3:06 p.m.) > > > Review request for Calligra. > > > Description > ------- > > The roundtripping for the document attached to the bug report fails > currently. This patch fixes the issue. > > > This addresses bug 299112. > http://bugs.kde.org/show_bug.cgi?id=299112 > > > Diffs > ----- > > libs/flake/KoImageCollection.h d0b1b64 > libs/flake/KoImageCollection.cpp 2965dd6 > libs/flake/KoShapeSavingContext.h 4801b29 > libs/flake/KoShapeSavingContext.cpp 34e729e > libs/kotext/opendocument/KoTextWriter_p.h 3f51ea6 > libs/kotext/styles/KoListLevelProperties.cpp f3dd4ff > > Diff: http://git.reviewboard.kde.org/r/104795/diff/ > > > Testing > ------- > > Checked roundtripping with the document attached to the bug > > > Thanks, > > Gopalakrishna Bhat > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
