-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104701/
-----------------------------------------------------------
Review request for Calligra.
Description
-------
There is a mismatch between reading and writing of the config entry "unit" for
a document:
all code writes that entry to "view-settings" group:
KarbonPart::saveOasisSettings(...)
KoPADocument::saveOdfSettings(...)
DocBase::saveOdfHelper(...)
KWOdfWriter::saveOdfSettings(...)
and most read it from there:
KarbonPart::loadOasisSettings(...)
KoPADocument::loadOdfSettings(...)
DocBase::loadOdfSettings(...)
But KWOdfLoader::loadSettings(...) only read from old (before odf 1.2?)
"ooo:view-settings", thus the bug.
While the attached patch fixes the bug, I wonder if KarbonPart, KoPADocument
and DocBase should also try "ooo:view-settings" for backward-compability?
Or should the patch be to just change "ooo:view-settings" to "view-settings",
ignoring any backward compatibility?
I could not find any documentation on the setting properties for ODF, so need
some with more clue to comment this.
This addresses bug 298510.
http://bugs.kde.org/show_bug.cgi?id=298510
Diffs
-----
words/part/KWOdfLoader.cpp c4cbcee
Diff: http://git.reviewboard.kde.org/r/104701/diff/
Testing
-------
Created a new document with Calligra Words, changed the unit to Pica, saved it,
closed Words. Restarted Words, load that document and see the settings updated
to Pica (already with the tuneKoUnit branch merged to master locally)
Thanks,
Friedrich W. H. Kossebau
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
