----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104553/ -----------------------------------------------------------
Review request for Calligra and Thorsten Zachmann. Description ------- The markers in the KoMarkerSelector have been somehow off. Also the line width has been different from the one in the line style selector. This patch changes this by having the marker model only deliver the marker, not a full line shape with the marker set and fixed end points for the line. The marker delegate and the marker selector now draw the line with the marker based on the available rect, similar to how the line selector does it. Some things still left to do/think about: * some margins to the left and right side of the line? * find a way to calculate the max height/width of the marker, to be used for the sizeHint/minSize per item * redo the whole stroke config widget and e.g. place marker selectors to the left and the right of the style selector But this patch already is a first improvement on its own IMHO. Agreed? Diffs ----- libs/widgets/KoMarkerItemDelegate.h c1e715a libs/widgets/KoMarkerItemDelegate.cpp f628479 libs/widgets/KoMarkerModel.h 3e44db0 libs/widgets/KoMarkerModel.cpp f21848f libs/widgets/KoMarkerSelector.h 3d7b9db libs/widgets/KoMarkerSelector.cpp 55cb302 Diff: http://git.reviewboard.kde.org/r/104553/diff/ Testing ------- Screenshots ----------- Before http://git.reviewboard.kde.org/r/104553/s/521/ After http://git.reviewboard.kde.org/r/104553/s/522/ Thanks, Friedrich W. H. Kossebau
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
