----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104415/ -----------------------------------------------------------
Review request for Calligra. Description ------- The three classes KoLineBorderFactory, KoShapeBorderFactoryBase and KoShapeBorderRegistry are not used anywhere at all, which can be seen by the minimal diff. I suggest to just remove them. The factory does nothing else than 'new KoLineBorder;', and the factory base is not inherited anywhere else. Noteworthy is that there are no similar classes for the other common shape attributes Fill and Shadow. Diffs ----- libs/flake/CMakeLists.txt 28e778f Diff: http://git.reviewboard.kde.org/r/104415/diff/ Testing ------- Not much testing for this one except building and installing. Thanks, Inge Wallin
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
