----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103846/#review10277 -----------------------------------------------------------
Good idea to hide the buttons when not applicable :) few improvements are needed, and then this can go in. active/qml/PresentationLeftToolbar.qml <http://git.reviewboard.kde.org/r/103846/#comment8452> this should be better- visible: root.documentController.documentHandler().currentSlideNumber > 1 active/qml/PresentationRightToolbar.qml <http://git.reviewboard.kde.org/r/103846/#comment8453> similarly, visible: root.documentController.documentHandler().currentSlideNumber < root.documentController.documentHandler().totalNumberofSlides active/qml/PresentationTopToolbar.qml <http://git.reviewboard.kde.org/r/103846/#comment8454> change "/" to " of " active/src/CAPresentationHandler.h <http://git.reviewboard.kde.org/r/103846/#comment8455> camelCase, 'of' should be 'Of' active/src/CAPresentationHandler.cpp <http://git.reviewboard.kde.org/r/103846/#comment8456> Ah my bad, move the emit below line 142 because currentSlideNum might change there - Shantanu Tushar Jha On Feb. 2, 2012, 5:41 a.m., Sujith Haridasan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103846/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2012, 5:41 a.m.) > > > Review request for Calligra and Shantanu Tushar Jha. > > > Description > ------- > > The following changes were made in this patch: > 1) Add the total number of slide number along with the current slide number. > 2) If the user views the first slide, hide the previous button(left button). > 3) If the user views the last slide, hide the next button( right button). > > > Diffs > ----- > > active/qml/PresentationLeftToolbar.qml bfdcc91 > active/qml/PresentationRightToolbar.qml 24ed0b2 > active/qml/PresentationTopToolbar.qml 7ebfec9 > active/src/CAPresentationHandler.h 1621be5 > active/src/CAPresentationHandler.cpp b5b1aea > > Diff: http://git.reviewboard.kde.org/r/103846/diff/diff > > > Testing > ------- > > 1) When user launches the CA with the presentation file open, he/she sees the > left button disabled if he/she is on the first slide of the presentation. As > user moves on to next slide(s) the previous slide button is displayed. > 2) When user reaches the last slide, he/she sees the right button disabled. > And cannot move to next slide( because its already the last slide). As the > user moves to previous slide(s) the next slide button is displayed. > 3) Checked the total slide number which is visible throughout the slide. > > > Thanks, > > Sujith Haridasan > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
