----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103778/#review10046 -----------------------------------------------------------
I looked at the xsl file. I feel it could do with more documentation. Which HTML are you converting to and why? Using xml output (so xhtml) is prefered since it is much better behaved. filters/words/html-odf/conversion/converter.xsl <http://git.reviewboard.kde.org/r/103778/#comment8280> output method html is scary. xml is much better behaved filters/words/html-odf/conversion/converter.xsl <http://git.reviewboard.kde.org/r/103778/#comment8279> The title element is obligatory in HTML. I think you mentioned that <title/> gives problems in some browsers, but <title></title> should be fine. At any rate the reasoning should be explained in a comment. filters/words/html-odf/conversion/converter.xsl <http://git.reviewboard.kde.org/r/103778/#comment8281> indentation does not hurt - Jos van den Oever On Jan. 24, 2012, 4:28 p.m., Stuart Dickson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103778/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2012, 4:28 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Improvements to the html-odf export filter. > > Added support for: exporting images, tables with merged cells. > Modifications to KoFilter derived class to incorporate Conversion class' > convert function and provide improved error checking. > Changes to output styles to improve legibility. > Disabled export filter dialog as it does not have an impact on output, but > can be modified in future. > Removing QChar::ObjectReplacementMarkers from appearing in output. > > The focus has been on the content and not on styles and there is still > improvement in cleaning up the generated output. > > > Diffs > ----- > > filters/words/html-odf/CMakeLists.txt d1bee3f > filters/words/html-odf/ManifestParser.h PRE-CREATION > filters/words/html-odf/ManifestParser.cpp PRE-CREATION > filters/words/html-odf/conversion/converter.xsl 1f01ed6 > filters/words/html-odf/convert.h 8cbdd6c > filters/words/html-odf/convert.cpp 226fbd5 > filters/words/html-odf/htmlodfexport.h bff8dec > filters/words/html-odf/htmlodfexport.cpp 5f0606e > > Diff: http://git.reviewboard.kde.org/r/103778/diff/diff > > > Testing > ------- > > Testing against a couple of sample documents including paragraphs, titles, > simple tables and ones with additional merged cells, inline and paragraph > anchored images. > > > Thanks, > > Stuart Dickson > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
