----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103710/#review9934 -----------------------------------------------------------
This review has been submitted with commit 9c4c3bef739950056898bd98cf375be8d8774f0d by Burkhard Lück to branch master. - Commit Hook On Jan. 16, 2012, 7:23 p.m., Burkhard Lück wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103710/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2012, 7:23 p.m.) > > > Review request for Calligra, Marijn Kruisselbrink and Sebastian Sauer. > > > Description > ------- > > FunctionDescription.cpp handles Types "Boolean", "Int", "String", "Any", > everything else > is treated as Float type-> that is wrong. > > There is also Reference, Array, Bool, String/Numeric, Reference/Array, Error, > FLOAT, int, IntType, Integer, Date, Double -> all treated as Float and > displayed with > that type in functions dialog. > > 1) changed all int/IntType/Integer to the proper Type string "Int" + Bool to > "Boolean" > > 2) removed sebsauers comments, this doesn't break string freeze, the msgs are > already in tables.pot > > 2) added some comments about issues to fixe for 2.5, breaks strings freeze > now. > > Not all issues mentioned in #290631 are fixed in this patch, > the types Reference, Array, String/Numeric, Reference/Array, Error, Date, > Double are still wrong. > > > This addresses bug 290631. > http://bugs.kde.org/show_bug.cgi?id=290631 > > > Diffs > ----- > > tables/functions/engineering.xml a9c5281 > tables/functions/financial.xml e54b400 > tables/functions/math.xml b495861 > tables/functions/reference.xml 2446021 > tables/functions/statistical.xml 1463231 > tables/functions/text.xml 6933622 > > Diff: http://git.reviewboard.kde.org/r/103710/diff/diff > > > Testing > ------- > > > Thanks, > > Burkhard Lück > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
