A more detailed comment to point 1: You mixed the MouseClickTextInfo, which is part of the TextContainerInteractiveInfo structure (our own structure to keep related information together) into a top level structure which purpose is to store a reference to text of the slide and it's padding, indent, tabs, etc. We are looking for TextContainerInteractiveInfo inside of the TextContainer, so I would try to catch it there and maintain the data structure we introduced.
I still doubt the file is worth the effort at the moment. We discussed a while ago to parse all the child containers into a map and recall the data on demand when processing the parent. -- Matus Uzak Software Designer Ixonos Slovakia s.r.o. Sturova 27, 040 01 Kosice, Slovakia mobile 0421 918 718 958 email: matus.u...@ixonos.com http://www.ixonos.com ________________________________________ From: calligra-devel-boun...@kde.org [calligra-devel-boun...@kde.org] on behalf of Uzak Matus [matus.u...@ixonos.com] Sent: Monday, January 09, 2012 5:52 PM To: Calligra Suite developers and users mailing list Subject: RE: Patch for msoscheme Hi Mani, I'm not happy about that patch (check the reasons below). Do you know which application produced that file? PowerPoint 2007 classified your test file as corrupt and displayed only a number of slides. PowerPoint 2003 did not complain (it usually does not complain ) but I don't know if the file was displayed properly. After re-save in PowerPoint 2003 the file was displayed identically by Stage. At the moment both the parser and the filter are not prepared to handle such files and I would prefer to revert such a change from msoscheme. Reasons: 1. We invented a number of own structures the keep related information together and make it logically sound to have the filter as readable as possible. Each of the choices defined therein arrives in a specific scenario or is used by a specific version of PowerPoint. You mixed MouseClickTextInfo into data which specify padding and indent and that is logically unsound. <struct name="TextClientDataSubContainerOrAtom"> <choice name="anon"> <type type="OutlineTextRefAtom" /> <type type="TextContainer" /> <type type="TextRulerAtom" /> + <type type="MouseClickTextInfo" /> </choice> </struct> 2. You introduced the following child of OfficeArtSpContainer : <type name="shapeTertiaryOptions2" type="OfficeArtTertiaryFOPT" optional="true" /> + <type name="shapePrimaryOptions2" type="OfficeArtFOPT" optional="true" /> This is not compliant with the MS-ODRAW specification, there are no shapePrimaryOptions2! From my experience MS-ODRAW containers always follow the Primary - Secondary - Tertiary order, so expecting shapePrimaryOptions2 to be saved after shapeSecondaryOptions2 and shapeTertiaryOptions2 is wrong. -- Matus Uzak Software Designer Ixonos Slovakia s.r.o. Sturova 27, 040 01 Kosice, Slovakia mobile 0421 918 718 958 email: matus.u...@ixonos.com http://www.ixonos.com ________________________________________ From: calligra-devel-boun...@kde.org [calligra-devel-boun...@kde.org] on behalf of Jos van den Oever [j...@vandenoever.info] Sent: Tuesday, January 03, 2012 1:17 PM To: Calligra Suite developers and users mailing list Subject: Re: Patch for msoscheme On Tuesday, January 03, 2012 12:43:18 PM Mani N C wrote: > Hi Jos, > > mso-patch for mso.xml will allow filters to parse the attached ppt file. > Though lot of style information are still missing, I can atleast view the > file. > I have tested calligrastage with couple of other files and it works > fine. If the patch is good enough, I will update Stage filter with this > patch. Thank you for the patch. It looks good and applies and compiles fine. I've pushed it to msoscheme and calligra. Only after pushing i saw that you have a branch on gitorious i could have pulled from. http://gitorious.org/msoscheme/msoscheme/commit/2b6d38010f1953ee96be087f4ec3e428ff2a1c06 Cheers, Jos _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
