> On Oct. 25, 2011, 8:17 p.m., Jarosław Staniek wrote:
> > Good job!

Dimitrios, please commit to kexi-tanis branch and mark this review as 
'submitted'.


- Jarosław


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102928/#review7613
-----------------------------------------------------------


On Oct. 25, 2011, 8:51 p.m., Dimitrios Tanis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102928/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2011, 8:51 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Description
> -------
> 
> A Simple patch adding automatic Changing of the Current ToolbarTab when 
> Switching to Design mode for forms/report respectively.
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.h 390532f 
>   kexi/main/KexiMainWindow.cpp f54e761 
>   kexi/main/KexiMainWindow_p.h 32d45f5 
> 
> Diff: http://git.reviewboard.kde.org/r/102928/diff/diff
> 
> 
> Testing
> -------
> 
> Compiles and runs without errors.
> 
> Minor issue. It works when switching to design view from the Project 
> Navigator, but it does NOT work when switching from the objects toolbar (ie 
> the toolbar displayed under the object tab).
> Maybe switching to design is implemented by two different slots? Looking into 
> it.
> 
> 
> Thanks,
> 
> Dimitrios Tanis
> 
>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to