----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103413/#review8966 -----------------------------------------------------------
Ship it! Please commit after fix the think I pointed out. tools/converter/calligraconverter.cpp <http://git.reviewboard.kde.org/r/103413/#comment7454> The i18n call needs to be removed as we are in stringfreeze at the moment. Please add a comment that it should be changed after 2.4 is released. - Thorsten Zachmann On Dec. 14, 2011, 7:28 p.m., Alex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103413/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2011, 7:28 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Cleaned a little bit calligraconverter.cpp by applying some general code > clean concepts such: > Return early > Return on errors > Do one thing on each function > > Is not much change but I think makes code clearer with less indentation etc. > > > Diffs > ----- > > tools/converter/calligraconverter.cpp 1baea00 > > Diff: http://git.reviewboard.kde.org/r/103413/diff/diff > > > Testing > ------- > > > Thanks, > > Alex Fiestas > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
