----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103171/#review8280 -----------------------------------------------------------
This review has been submitted with commit 8d0def5dd64341d20c0988c858af6bd2c3aaf3da by Jaime Torres to branch master. - Commit Hook On Nov. 17, 2011, 6:43 p.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103171/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2011, 6:43 p.m.) > > > Review request for Calligra. > > > Description > ------- > > I'm still not able to compile calligra with clang 2.99.9999, but some > meaningful warnings are produced. > Instead of doing a comparation and loose the result, set the value. > Return 0 (as nullptr) instead of false. > > > Diffs > ----- > > filters/words/rtf/import/rtf-qt/src/UserPropsDestination.cpp 4e6d185 > plan/libs/models/kptnodeitemmodel.cpp 1ecb9f4 > > Diff: http://git.reviewboard.kde.org/r/103171/diff/diff > > > Testing > ------- > > still compiles with g++ > > > Thanks, > > Jaime Torres Amate > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
