----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102790/#review7862 -----------------------------------------------------------
please close this review - C. Boemann On Oct. 6, 2011, 1:11 p.m., Stuart Dickson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102790/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2011, 1:11 p.m.) > > > Review request for Calligra. > > > Description > ------- > > Removing libgsf dependency from msword-odf filter, replacing with existing > POLE support in libmso. > Using olestream and olestorage within wv2/src as a Facade to Pole. > Cleaned up these classes, removing unused members. > Some more cleanup changes in separate commits. > This change makes msword-odf compile on Windows for the first time. > > > Diffs > ----- > > filters/words/CMakeLists.txt e5f0d64 > filters/words/msword-odf/CMakeLists.txt a6dd0cb > filters/words/msword-odf/document.cpp 3dcabf6 > filters/words/msword-odf/graphicshandler.cpp f2f9519 > filters/words/msword-odf/msdoc.h 460c5c4 > filters/words/msword-odf/paragraph.cpp f7988de > filters/words/msword-odf/tablehandler.h 18167df > filters/words/msword-odf/tablehandler.cpp 8b290e9 > filters/words/msword-odf/texthandler.h 5fb28d5 > filters/words/msword-odf/texthandler.cpp 4e85fda > filters/words/msword-odf/wv2/CMakeLists.txt 2fc0d70 > filters/words/msword-odf/wv2/src/CMakeLists.txt 41c95d5 > filters/words/msword-odf/wv2/src/annotations.cpp 722edeb > filters/words/msword-odf/wv2/src/bookmark.cpp 93e14ee > filters/words/msword-odf/wv2/src/crc32.h d51bb13 > filters/words/msword-odf/wv2/src/fields.cpp 03bdcce > filters/words/msword-odf/wv2/src/footnotes97.cpp 0d29d36 > filters/words/msword-odf/wv2/src/functordata.h dcb9b28 > filters/words/msword-odf/wv2/src/graphics.cpp 4057822 > filters/words/msword-odf/wv2/src/handlers.h b1c8280 > filters/words/msword-odf/wv2/src/headers.cpp a2039bf > filters/words/msword-odf/wv2/src/lists.cpp 908ecf8 > filters/words/msword-odf/wv2/src/olestorage.h bf768e0 > filters/words/msword-odf/wv2/src/olestorage.cpp a949657 > filters/words/msword-odf/wv2/src/olestream.h 32d589a > filters/words/msword-odf/wv2/src/olestream.cpp 01c0612 > filters/words/msword-odf/wv2/src/parser9x.cpp 679ce78 > filters/words/msword-odf/wv2/src/parserfactory.h 3873660 > filters/words/msword-odf/wv2/src/parserfactory.cpp 0b86c09 > filters/words/msword-odf/wv2/src/properties97.cpp 71e40ce > filters/words/msword-odf/wv2/src/styles.cpp f1f8f13 > filters/words/msword-odf/wv2/src/ustring.cpp d840207 > filters/words/msword-odf/wv2/src/word97_generated.cpp bd7ae2a > filters/words/msword-odf/wv2/src/word97_helper.h fe9bcbf > filters/words/msword-odf/wv2/src/word97_helper.cpp 95d812c > filters/words/msword-odf/wv2/src/word_helper.h 5c5f6e9 > filters/words/msword-odf/wv2/src/zcodec.hxx a099fc1 > filters/words/msword-odf/wv2/src/zcodec.cxx 6fee148 > filters/words/msword-odf/wv2/tests/CMakeLists.txt 249a156 > filters/words/msword-odf/wv2/tests/handlertest.cpp d94b3b5 > filters/words/msword-odf/wv2/tests/helpertest.cpp a8bc99f > filters/words/msword-odf/wv2/tests/iconvtest.cpp e53851c > filters/words/msword-odf/wv2/tests/oletest.cpp dfaa144 > filters/words/msword-odf/wv2/tests/parsertest.cpp 5493e84 > filters/words/msword-odf/wv2/tests/parsertest_mem.cpp d004453 > filters/words/msword-odf/wv2/tests/regression 1225b45 > filters/words/msword-odf/wv2/tests/sharedptrtest.cpp 83e1fcf > filters/words/msword-odf/wv2/tests/test.h 18ddee0 > filters/words/msword-odf/wv2/tests/testole.doc dd94bba > filters/words/msword-odf/wv2/tests/ustringtest.cpp b26af18 > filters/words/msword-odf/wv2/tests/word95_test.cpp 2351c78 > filters/words/msword-odf/wv2/tests/word97_test.cpp 902dfc8 > libs/kotext/KoTextCommandBase.h 2cf3f63 > > Diff: http://git.reviewboard.kde.org/r/102790/diff/diff > > > Testing > ------- > > Loaded documents and run cstester for comparison against previous, libgsf > version. > > > Thanks, > > Stuart Dickson > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
