----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102871/#review7353 -----------------------------------------------------------
In general I like this change. It lessens the problem with dockers being too big or many to fit in the dockwidgets. It improves the overview a lot. But I have a big problem with the part that removes certain tools; see the extended comment below. karbon/plugins/tools/KarbonGradientToolFactory.cpp <http://git.reviewboard.kde.org/r/102871/#comment6432> I'm very uncomfortable with this change and the next for the following reasons: * Graphics contents, including gradients and patterns, is very common in text documents. In my opinion these tools should be made part of the standard Calligra set of tools for productivity applications instead of being disabled. But I guess that's a topic for the mailing list rather than the review board. Or perhaps even the sprint. * I think we should have a similar set of tools, especially for graphics, in the 3 productivity apps Words, Stage and Tables. Only disabling them in Words leads to surprises for users. * I don't think these changes are so tightly connected to the new mode box that they need to be in the same patch even if they were voted through. So I suggest removing them for this patch and start a thread on them on the ML. I'm more hesitant about the change for the calligraphy tool and the filter effect tool, so I'll just keep quiet on them. - Inge Wallin On Oct. 15, 2011, 4:49 p.m., C. Boemann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102871/ > ----------------------------------------------------------- > > (Updated Oct. 15, 2011, 4:49 p.m.) > > > Review request for Calligra. > > > Description > ------- > > This UI was conceived during the KDE User Experience sprint in Berlin 2011 > > It basically provides a drop-in-replacement for the toolbox + > tooloptionsdocker in the form of a single docker containing QToolBox widget. > > The new KoModeBox is used in Words only. All the other applications should be > left unchanged. > > The tools have a new extended usage of the Type attribute. See the > KoToolFactoryBase.h changes for description. It should be compatible with the > krita usage. > The only visible changes outside Words would probably be that the gradient, > pattern,calligraphy tools end up in a separate section of the toolbox. > > > Diffs > ----- > > karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyToolFactory.cpp > cb1c092 > karbon/plugins/tools/KarbonGradientToolFactory.cpp 786d98a > karbon/plugins/tools/KarbonPatternToolFactory.cpp 1ec250fa > karbon/plugins/tools/KarbonPencilToolFactory.cpp 4fd1105 > karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsToolFactory.cpp > c30f1be > libs/flake/KoToolFactoryBase.h 73f2534 > libs/flake/KoToolManager.cpp 3bcae08 > libs/main/CMakeLists.txt 9539a5a > libs/main/KoDockerManager.h 7e44455 > libs/main/KoDockerManager.cpp 7f5b17d > libs/main/KoModeBox.cpp PRE-CREATION > libs/main/KoModeBoxFactory.h PRE-CREATION > libs/main/KoModeBoxFactory.cpp PRE-CREATION > libs/main/KoModeBox_p.h PRE-CREATION > libs/main/KoToolBox.cpp ede46d4 > plugins/textshape/ReferencesToolFactory.cpp 096e602 > plugins/textshape/ReviewToolFactory.cpp bbd6452 > plugins/textshape/TextToolFactory.cpp 438846c > words/part/KWGui.cpp 69d309b > > Diff: http://git.reviewboard.kde.org/r/102871/diff/diff > > > Testing > ------- > > > Screenshots > ----------- > > screentshot of the new ui > http://git.reviewboard.kde.org/r/102871/s/306/ > toolbox in karbon > http://git.reviewboard.kde.org/r/102871/s/307/ > toolbox in krita > http://git.reviewboard.kde.org/r/102871/s/308/ > toolbox in stage > http://git.reviewboard.kde.org/r/102871/s/309/ > > > Thanks, > > C. Boemann > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
