> On Sept. 11, 2011, 4:35 a.m., Thorsten Zachmann wrote: > > The fo:clip is a property of the style:graphic-property and can be used as > > that by all types of objects. Using it inside the pictureshape is there for > > wrong in my understanding as all shapes should support it. > > > > Also there is a KoShape::setClipPath which makes it very simple to clip > > what can be painted by a shape. I think it would be good if we would use > > the same functionality for that patch. It is not as easy to do as odf > > according to fo:clip only supports rect but svg where this functionality > > comes from supports also individual path. > > > > Using this will make it aslo very cheep to do the clipping. > > > > So in my point of view the clip path should be loaded/saved in KoShape > > styles loading/saving. Maybe extend KoClipPath to also set a QRectF in it. > > Jan might be able to give some hints there.
I had a discussion with jahm on IRC yesterday and he too mentioned using KoShape::setClipPath. But KoImageData does caching of pixmaps which makes rendering faster. Also for a clipped image a smaller pixmap is loaded to memory in KoImageData against the whole shape loaded in KoShape. Regarding your comment on clip path loading and saving we can discuss on IRC - Gopalakrishna ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102570/#review6410 ----------------------------------------------------------- On Sept. 10, 2011, 5:26 p.m., Gopalakrishna Bhat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102570/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2011, 5:26 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Adds support to fo:clip ODF property. In > https://bugs.kde.org/show_bug.cgi?id=281531 the whole image is scaled and > shown insted of clipping. With this patch pictureshape now supports clipping. > Known Issue: The doc file attacted to the bug report will be displayed as > before because of the filter problem. If the MS doc file is converted to ODT > using LO or OOo and then opened in Words the image is displayed similar to LO > or OOo. > > > This addresses bug 281531. > http://bugs.kde.org/show_bug.cgi?id=281531 > > > Diffs > ----- > > libs/flake/KoImageData.h 3556100 > libs/flake/KoImageData.cpp da93926 > libs/flake/KoImageData_p.h 6eba4bc > plugins/pictureshape/PictureShape.h 5c362fb > plugins/pictureshape/PictureShape.cpp cba8cc4 > > Diff: http://git.reviewboard.kde.org/r/102570/diff > > > Testing > ------- > > Converted the MS doc file attached to > https://bugs.kde.org/show_bug.cgi?id=281531 to ODT in LO and saw that the > picture is displayed similarly in LO and Words. > > > Thanks, > > Gopalakrishna > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
