some ifs easy to fix if you remember what do you wanted to achieve

[Jaime]

Hi,

 There are some ifs that I do not know how to fix.. (duplicated or
comparing the same value).

kexi/widget/tableview/kexitextformatter.cpp around line 165
    bool KexiTextFormatter::valueIsEmpty(const QString& text) const
             return d->dateFormatter->isEmpty(text);
         else if (t == KexiDB::Field::Time)
             return d->timeFormatter->isEmpty(text);
        else if (t == KexiDB::Field::Time)
             return dateTimeIsEmpty(*d->dateFormatter, *d->timeFormatter, text);
     }

krita/plugins/formats/jp2/jp2_converter.cc around line 166
  KisImageBuilder_Result jp2Converter::decode(const KUrl& uri)
     if (!hasColorSpaceInfo) {
         if (components == 3) {
             image->color_space = CLRSPC_SRGB;
       } else if (components == 3) {
             image->color_space = CLRSPC_GRAY;
         }
     }

krita/ui/widgets/kis_light_stage.cpp around line 124
QVector<qreal> KisLightStage::semiSphericalHeightmap()
             inclination = acos(rm);

             rz = sin(inclination);
             if (rz != rz) {                // Checking for NaN??????
Isn't there a isNaN()?
                 foreverAlone << 0;
             } else {

tables/Style.cpp around line 622 and 646, 602 and 656

    else if (_format == "yyyy/MMM/dd")
        return Format::Date14;
    else if (_format == "yyyy/MMM/dd")
        return Format::Date26;

    else if (_format == "dd-MM")
        return Format::Date4;
    else if (_format == "dd-MM")
        return Format::Date31;

tables/dialogs/LayoutDialog.cpp around line 3457 and 3482

    if (dlg->brushStyle == Qt::VerPattern) {
        brush1->slotSelect();
    } else if (dlg->brushStyle == Qt::VerPattern) {
        brush13->slotSelect();

Best Regards.
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel