----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102474/#review6089 -----------------------------------------------------------
kexi/kexidb/drivers/mySQL/mysqlconnection.cpp <http://git.reviewboard.kde.org/r/102474/#comment5377> OK, but to be strict 'success' is always set in resultExists(). kexi/main/KexiMainWindow.cpp <http://git.reviewboard.kde.org/r/102474/#comment5378> definitely not needed, 'data' set in all cases here; please remove kexi/main/KexiMainWindow.cpp <http://git.reviewboard.kde.org/r/102474/#comment5379> checking for data here can be removed - Jarosław On Aug. 28, 2011, 11:55 a.m., Jaime Torres Amate wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102474/ > ----------------------------------------------------------- > > (Updated Aug. 28, 2011, 11:55 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > Add null pointer safeguards > Initialize some variables that could be used uninitialized > change a parameter to be passed by reference > > > Diffs > ----- > > kexi/formeditor/commands.cpp 0508a92 > kexi/formeditor/editlistviewdialog.cpp 31245d1 > kexi/kexidb/drivers/mySQL/mysqlconnection.cpp a5c8228 > kexi/kexidb/drivers/oracle/oracleconnection.cpp 7634c73 > kexi/kexidb/drivers/oracle/oracleconnection_p.cpp 29bfe1f > kexi/kexidb/drivers/pqxx/pqxxconnection.cpp eb3029c > kexi/kexidb/drivers/sqlite/sqliteconnection.cpp 9c4e676 > kexi/kexidb/drivers/sybase/sybaseconnection.cpp 32437f4 > kexi/kexidb/drivers/xbase/xbaseconnection.cpp 351ac3d > kexi/kexidb/utils.h f941a08 > kexi/main/KexiMainWindow.cpp 104849b > kexi/main/printing/kexisimpleprintingpagesetup.cpp 37f6fa2 > kexi/plugins/forms/kexiformview.cpp 105b5f9 > > Diff: http://git.reviewboard.kde.org/r/102474/diff > > > Testing > ------- > > no change in make test > > > Thanks, > > Jaime Torres > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
