----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102200/#review5408 -----------------------------------------------------------
Hello Pierre, I would like to run cstester on it to see if nothing got broken. Can you please wait until I have done the test. Thanks, Thorsten - Thorsten On Aug. 3, 2011, 8:50 p.m., Pierre Ducroquet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102200/ > ----------------------------------------------------------- > > (Updated Aug. 3, 2011, 8:50 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > First refactoring of KoText table borders : > - get rid of the rendering code that was sitting in kotext/styles and move it > to its own class in textlayout > - simplify KoTableCellStyle by kicking KoTableBorderStyle and removing the > edges/borders private members > > Next step : get rid of most of these properties and replace them with a > KoBorder property. > > > Diffs > ----- > > filters/libmsooxml/MsooXmlDrawingTableStyleReader.cpp > 849d4bad4d5b6e9f7a658d1f9def3092486c0b27 > filters/words/docx/DocxXmlDocumentReader.cpp > 98ddcf56cfbc08c6d109a9f2b4967695f6022cf9 > libs/kotext/CMakeLists.txt 46c194fc27d3fd6437675afd90e96833e75df7f0 > libs/kotext/KoTextBlockBorderData.cpp > c829b5cd857f004d60002a09b2ba38b4b60bd065 > libs/kotext/KoTextDebug.cpp 3d65b666efb1dfee24b9054e5c6346d454bd31df > libs/kotext/KoTextEditor.cpp 70c421d6011e7871a17acca1b2a91f80cf553c0f > libs/kotext/opendocument/tests/TestLoading.cpp > c36deda2816a2709e965208adca41d41a7e17672 > libs/kotext/styles/KoTableBorderStyle.h > 2bb46dd9c91398ef29928de97a027d3e09a73b2a > libs/kotext/styles/KoTableBorderStyle.cpp > ab88d8d2d555996d38d900a9ebb6bada668378f7 > libs/kotext/styles/KoTableBorderStyle_p.h > ca9d32d2466fbb808791a3d23618b2e3bb778a34 > libs/kotext/styles/KoTableCellStyle.h > dfb6967b846b21e6608e74a55f06441265df900b > libs/kotext/styles/KoTableCellStyle.cpp > f68cd03d93f048dbfcded91d53e51c2737c4b7a9 > libs/kotext/styles/KoTableCellStyle_p.h > 3935c8190bc4f0c8c40f01886d9a7279fc22b689 > libs/kotext/styles/tests/TestTableCellStyle.cpp > e752e239db388f9144d13f575da0b1c52abc1689 > libs/odf/KoBorder.h c7b9b5d97772569026dfc6bf3723ee93f7331f8a > libs/odf/KoBorder.cpp 4772305867b260acd76dab549c9de5ebeaaceb6a > libs/textlayout/CMakeLists.txt a364ac50240e8bd6e93d9aca73c43ae426d1bfd1 > libs/textlayout/KoTextLayoutCellHelper.h PRE-CREATION > libs/textlayout/KoTextLayoutCellHelper.cpp PRE-CREATION > libs/textlayout/KoTextLayoutTableArea.cpp > 28aebe3a949fd089619ab686a984ccc9333160ee > words/part/KWCanvasBase.cpp 9589f08dd172b097771369929f777e35b4d7f7dc > > Diff: http://git.reviewboard.kde.org/r/102200/diff > > > Testing > ------- > > - Compilation > - Running unit tests > - Rendering of sample documents > > > Thanks, > > Pierre > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
