----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102127/ -----------------------------------------------------------
Review request for Calligra, Pierre Stirnweiss and Casper Boemann. Summary ------- Using KoToolProxy->selection and casting that into a KoTextEditor is is confusing: it is meant to allow access to the selection, not to allow access to the complete contents of a shape. The KoTexSelectionHandler to KoTextEditor change was meant to get away from the dependency on the active tool. Now we get the selected shape from the active canvas and if it has the right userdata, get the right KoTextEditor from it, and use that to insert the variable. Also, KoTextEditor now return the variable instead of a bool, because the InsertInlineObjectActionBase::createInlineObject wants to return that object. Diffs ----- libs/kotext/InsertTextLocator.cpp 2195a02 libs/kotext/KoTextEditor.h 02d0ef1 libs/kotext/KoTextEditor.cpp 70c421d Diff: http://git.reviewboard.kde.org/r/102127/diff Testing ------- Thanks, Boudewijn
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
