----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102120/#review5198 -----------------------------------------------------------
>From looking at the patch it looks quite good. I will try to test it tomorrow. kpresenter/part/KPrSlidesSorterDocumentModel.cpp <http://git.reviewboard.kde.org/r/102120/#comment4706> The opening { should be in the same line as the if. There should be no banks afrer ( and before ) kpresenter/part/KPrViewModeSlidesSorter.cpp <http://git.reviewboard.kde.org/r/102120/#comment4707> Please use ++i instead of i++ as the first one does not create a temporary object. libs/kopageapp/KoPADocumentModel.cpp <http://git.reviewboard.kde.org/r/102120/#comment4709> please make this a static const libs/kopageapp/KoPADocumentModel.cpp <http://git.reviewboard.kde.org/r/102120/#comment4708> The opening { should be in the same line as the for libs/main/KoDocumentSectionView.cpp <http://git.reviewboard.kde.org/r/102120/#comment4710> Please fix indention and remove the empty lines libs/main/KoDocumentSectionView.cpp <http://git.reviewboard.kde.org/r/102120/#comment4711> This can be a also moved into a else if - Thorsten On July 28, 2011, 6:46 p.m., Paul Mendez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102120/ > ----------------------------------------------------------- > > (Updated July 28, 2011, 6:46 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Review of GSoC Project Advance: > > this patch include: > The following features for Document Structure Docker: > - Integration of +/- selection buttons > - Draw thumbnails of dragged pages > - Show context menu on dropping for copy/paste pages. > - Improve moving pages. > Also: > - Move KPrSelectionManager and KPrSelectionToggle classe to libs/widgets and > rename to: > KoSelectionManager, KoSelectionToggle (these classes provide +/- selection > buttons for QAbstracView classes). > - Selection of pages after move/copy on Custom Slide Shows View. > > > Diffs > ----- > > kpresenter/part/CMakeLists.txt 6a2142fee3a54dde3b40acd6f6a5369d3a7d60ea > kpresenter/part/KPrCustomSlideShowsModel.h > 5fed393c14ec50632519cdf91c11ff2055d1366c > kpresenter/part/KPrCustomSlideShowsModel.cpp > 7fe4192b597a9cca7c85df8684ca6fa9f610af3f > kpresenter/part/KPrSelectionManager.h > 5c45b7df03b69397ad56a15f4eb046956100a424 > kpresenter/part/KPrSelectionManager.cpp > a2fcc655047d2acb2ca06c3497c206f0ba4719ea > kpresenter/part/KPrSelectionToggle.h > 9645a17d1fca431f2bbe4059de89afb1b0487118 > kpresenter/part/KPrSelectionToggle.cpp > 92ffc997f8b086dc5747a003e1976cf6bffb2a67 > kpresenter/part/KPrSlidesManagerView.cpp > a406cdab7d467a1aaafeb5fe893394687866b135 > kpresenter/part/KPrSlidesSorterDocumentModel.cpp > 6073928e5d68de0c54611fe91db4047bef771439 > kpresenter/part/KPrViewModeSlidesSorter.h > a87c39c342b8db5a9ed63188d6fff75ae02a053c > kpresenter/part/KPrViewModeSlidesSorter.cpp > 6940cf97cd02d75a5644f7b363f0018febd4a7d9 > libs/kopageapp/KoPADocumentModel.h 957403493816dc501d071ccb4e949c56e467bc56 > libs/kopageapp/KoPADocumentModel.cpp > 1764e0b1e6fe78ff2a4f043ec8839961524aeb17 > libs/kopageapp/KoPADocumentStructureDocker.h > 6ac2e089fa9a57002ff0128f5cbd813037879506 > libs/kopageapp/KoPADocumentStructureDocker.cpp > a17e85c2cf8c71408d85abe960c2e12ed4c9be4f > libs/main/KoDocumentSectionView.h d4eeb9678ee19048ca0a36cb7c876fbea2539386 > libs/main/KoDocumentSectionView.cpp > 8efc246c7a86feac20d8f19518b1681567583ba1 > libs/widgets/CMakeLists.txt e261e00ee4386d94f56f38c924f2128ad496a7b8 > libs/widgets/KoSelectionManager.h PRE-CREATION > libs/widgets/KoSelectionManager.cpp PRE-CREATION > libs/widgets/KoSelectionToggle.h PRE-CREATION > libs/widgets/KoSelectionToggle.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102120/diff > > > Testing > ------- > > build and run. > > > Thanks, > > Paul > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
