----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102070/#review5028 -----------------------------------------------------------
Ship it! I ran the unittests, tested shape manipulation with Words as well and all looks well. Maybe it would be good to add a comment because the code looks pretty weird. - Boudewijn On July 24, 2011, 2:38 a.m., Sven Langkamp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102070/ > ----------------------------------------------------------- > > (Updated July 24, 2011, 2:38 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > When the interaction strategy is canceled it will create the command and undo > it. Problem here is that the application may rely on the redo command being > executed before that (see bug 278176). Patch adds the missing redo to fix > that.a > > > This addresses bug 278176. > http://bugs.kde.org/show_bug.cgi?id=278176 > > > Diffs > ----- > > libs/flake/tools/KoInteractionStrategy.cpp bd94057 > > Diff: http://git.reviewboard.kde.org/r/102070/diff > > > Testing > ------- > > Tested with 278176. > > > Thanks, > > Sven > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
