----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101951/#review4733 -----------------------------------------------------------
Ship it! Looks fine to me, but I cannot really test it here. - Boudewijn On July 15, 2011, 2:47 a.m., Raphael Kubo da Costa wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101951/ > ----------------------------------------------------------- > > (Updated July 15, 2011, 2:47 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > When iconv is installed in a path not searched by default by the compiler > (such as /usr/local on FreeBSD), the wv2 checks for iconv fail, as the linker > does not find libiconv.so to link to it and the compiler cannot find iconv.h. > > This patch passes ICONV_LIBRARIES and ICONV_INCLUDE_DIR to the try_run call, > making sure the program compiles and links fine. > > > Diffs > ----- > > filters/words/CMakeLists.txt 22c5115 > > Diff: http://git.reviewboard.kde.org/r/101951/diff > > > Testing > ------- > > The FreeBSD user who was having wv2 detection problems says it worked fine. > > > Thanks, > > Raphael > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
