-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101415/#review4002
-----------------------------------------------------------
Usually, we don't link separately to a library that is already linked to a
library we already link to, but export the linkage like this:
target_link_libraries(komain LINK_INTERFACE_LIBRARIES kotext kowidgets
${KDE4_KPARTS_LIBS})
where LINK_INTERFACE_LIBRARIES makes sure that everything linked to komain is
linked to kotext and kowidgets and doesn't have to explicitly link. I think it
would be good to export kundo2 with the first library that links to it in the
hierarchy.
- Boudewijn
On May 22, 2011, 12:20 p.m., Alexander Potashev wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101415/
> -----------------------------------------------------------
>
> (Updated May 22, 2011, 12:20 p.m.)
>
>
> Review request for Calligra.
>
>
> Summary
> -------
>
> Add target_link_libraries(... kundo2) to CMakeLists.txt files of all
> modules of Calligra that use Qt's Undo Framework.
>
>
> Requires https://git.reviewboard.kde.org/r/101414/
>
>
> Diffs
> -----
>
> braindump/plugins/stateshape/CMakeLists.txt 72c38eb
> braindump/plugins/webshape/CMakeLists.txt 5234f63
> karbon/common/CMakeLists.txt e940d9f
> karbon/plugins/flattenpath/CMakeLists.txt f83620b
> karbon/plugins/refinepath/CMakeLists.txt caf6aa7
> karbon/plugins/roundcorners/CMakeLists.txt 82b7159
> karbon/plugins/tools/CMakeLists.txt 7e4aeb6
> karbon/plugins/whirlpinch/CMakeLists.txt 2e920e2
> karbon/ui/CMakeLists.txt 0773216
> kexi/formeditor/CMakeLists.txt 0f48560
> kexi/plugins/forms/CMakeLists.txt 8d9c2d8
> kformula/CMakeLists.txt 8f46594
> kformula/flake/CMakeLists.txt 5b3b7bc
> kplato/CMakeLists.txt 605535f
> kplato/libs/kernel/CMakeLists.txt 6dc30b1
> kplato/libs/models/CMakeLists.txt ad9f50c
> kplato/libs/ui/CMakeLists.txt 6d64c1c
> kplato/workpackage/CMakeLists.txt b9ef576
> kpresenter/part/CMakeLists.txt a2b01ee
> kpresenter/plugins/eventactions/CMakeLists.txt e4810cd
> krita/image/CMakeLists.txt 47d13c3
> krita/plugins/extensions/dockers/historydocker/CMakeLists.txt 513dae3
> krita/plugins/tools/tool_transform2/CMakeLists.txt fe93230
> krita/ui/CMakeLists.txt 517adb6
> libs/flake/CMakeLists.txt c2164b7
> libs/kopageapp/CMakeLists.txt 4cdf024
> libs/kopageapp/tools/backgroundTool/CMakeLists.txt ba1ddc3
> libs/kotext/CMakeLists.txt bacba79
> libs/main/CMakeLists.txt 55a71a3
> libs/textlayout/CMakeLists.txt 4fb35c5
> plugins/artistictextshape/CMakeLists.txt 638edac
> plugins/chartshape/CMakeLists.txt 2daccfc
> plugins/defaultTools/CMakeLists.txt 6c7f138
> plugins/musicshape/CMakeLists.txt 3fa3d87
> plugins/pathshapes/CMakeLists.txt e773367
> plugins/pictureshape/CMakeLists.txt 373c589
> plugins/textshape/CMakeLists.txt a583a2a
> plugins/treeshape/CMakeLists.txt da0917d
> plugins/vectorshape/CMakeLists.txt b629e7f
> plugins/videoshape/CMakeLists.txt 697ed5b
> tables/CMakeLists.txt a6445ba
> tools/koabstraction/CMakeLists.txt f9b3882
> words/part/CMakeLists.txt dd3b917
>
> Diff: http://git.reviewboard.kde.org/r/101415/diff
>
>
> Testing
> -------
>
> This cannot possibly break anything. Of course, if you have already applied
> https://git.reviewboard.kde.org/r/101414/
>
>
> Thanks,
>
> Alexander
>
>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
