On Monday 06 June 2011 Jun, you wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101521/#review3721 > ----------------------------------------------------------- >
I'm replying directly to save some traffic... > > Looks great. Just some things; > > 1. In the dox there is a replacement of "&koffice;" with "Calligra". I am not > sure there but it seems in docbook "&...;" is something special. Yes, those are entities. I'm not sure how to handle those properly... Anyone a suggestion where &koffice; was defined? > > 2. For Kexi we do; > INSERT INTO "kexi__parts" > VALUES(1,'Tables','kexi/table','http://calligra.org/kexi/'); > INSERT INTO "kexi__parts" > VALUES(2,'Queries','kexi/query','http://calligra.org/kexi/'); > INSERT INTO "kexi__parts" > VALUES(3,'Formularze','kexi/form','http://calligra.org/kexi/'); > INSERT INTO "kexi__parts" > VALUES(4,'Reports','kexi/report','http://www.calligra-suite.org/kexi/'); > INSERT INTO "kexi__parts" > VALUES(5,'Scripts','kexi/script','http://www.calligra-suite.org/kexi/'); > INSERT INTO "kexi__parts" > VALUES(7,'Macros','kexi/macro','http://www.calligra-suite.org/kexi/'); > > Can that be a compatibility-problem, Jaroslaw? > > 3. I would suggest to also grep and replace for calligra.org => > calligra-suite.org cause it seems some strings still have calligra.org. Also > searching for "org.calligra." shows still some places (e.g. dbus-names) that > are wrong (would need to be "org.kde.calligra."). Good point. I only checked for www.calligra.org, which is also the reason for the kexi weirdnesses -- I'll do these changes as well. > > Everything else seems to be correct :) > -- Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
