-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101467/
-----------------------------------------------------------
(Updated May 29, 2011, 3:48 p.m.)
Review request for Calligra.
Changes
-------
I changed the diff file by merging master into the branch
krita_resource-management-tagging-tiyyagura and then creating the diff file
between the branches.
I updated the changes suggested by Boudewijn Rempt and also removed some spaces
in the code.
Summary
-------
Review request for the branch krita_resource-management-tagging-tiyyagura under
calligra repository
I want to merge this branch into master. Before that, I want to review it
first. I already tried to post this review using post-review but it is giving
error like this
File "/usr/lib/python2.7/httplib.py", line 809, in _send_output
msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc5 in position 44353:
ordinal not in range(128)
So, I created a diff file between master and
krita_resource-management-tagging-tiyyagura branch using the following command
and posting that diff file
git diff master krita_resource-management-tagging-tiyyagura
I didn't know whether this way is correct or wrong ? If it is wrong, please
intimate me with correct procedure.
Diffs (updated)
-----
krita/data/CMakeLists.txt 4b07140
krita/data/kritabrushes.knsrc PRE-CREATION
krita/data/kritagradients.knsrc PRE-CREATION
krita/data/kritapatterns.knsrc PRE-CREATION
krita/data/kritapresets.knsrc PRE-CREATION
krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp 55efdec
krita/ui/kis_paintop_box.cc aeebcae
krita/ui/widgets/kis_gradient_chooser.cc 86ecfdf
krita/ui/widgets/kis_pattern_chooser.cc 5b6661b
krita/ui/widgets/kis_preset_chooser.cpp c0da30d
libs/widgets/KoResourceItemChooser.h eee16cb
libs/widgets/KoResourceItemChooser.cpp 03cd55c
libs/widgets/KoResourceModel.cpp b007740
libs/widgets/KoResourceServer.h cd9e42b
libs/widgets/KoResourceServerAdapter.h dacc12f
libs/widgets/KoResourceServerProvider.cpp 27f2203
Diff: http://git.reviewboard.kde.org/r/101467/diff
Testing
-------
Thanks,
Srikanth
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
