> On May 3, 2011, 10:17 p.m., Pierre Ducroquet wrote: > > Hi > > > > Nice work, but I've got two questions : > > - where is that defined in the OpenDocument specification ? I can not find > > it, and it was never reported by the automated unit tests... > > - did you check whether the tests still compiled ? > > > > Thanks
15.11.12 <text-properties> says that the element is usable within <style:style> it does not say that it would require a certain family to be used. Libreoffice seems to interpret this in the way that it's usable within cell styles as they sometimes generate such documents. With unittests: Before the patch in TestOpenDocumentStyle 4 pass / 35 failed, seems like a major reason is that cellstyle does not save many things in saveOdf After the patch, the situation is the same. ie patch does not affect the situation in anyway. - Lassi Taneli ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101281/#review3092 ----------------------------------------------------------- On May 4, 2011, 8:45 a.m., Lassi Taneli Nieminen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101281/ > ----------------------------------------------------------- > > (Updated May 4, 2011, 8:45 a.m.) > > > Review request for Calligra. > > > Summary > ------- > > Odf allows text properties for cell-styles, previous kotext did not support > this. > This patch adds support for that. > > > Diffs > ----- > > libs/kotext/styles/KoTableCellStyle.cpp ecae702 > libs/kotext/opendocument/KoTextSharedLoadingData.cpp 532c752 > libs/kotext/styles/KoTableCellStyle.h 89e3862 > libs/kotext/opendocument/KoTextSharedLoadingData.h 0348049 > libs/kotext/styles/KoTableCellStyle_p.h 15f4dfe > libs/kotext/styles/tests/TestOpenDocumentStyle.h 89d7c5c > libs/kotext/styles/tests/TestOpenDocumentStyle.cpp cd44e03 > > Diff: http://git.reviewboard.kde.org/r/101281/diff > > > Testing > ------- > > > Thanks, > > Lassi Taneli > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
