On 26 April 2011 20:22, Shantanu Tushar Jha <jhahon...@gmail.com> wrote:
> The two things I needed to copy were -
>

Thanks for the feedback.
> 1. the functions which detect presentation types from extensions, I think
> these should be static in KOAbstraction.

First thing first: is there reason we cannot have instance derived
from KoAbstractApplicationController in QML-based application? I am
asking because the goal is to have KoAbstractApplicationController not
tied to QWidget-based or QML-based apps (it's controller part of MVC,
after all).

bool isPresentationDocumentExtension(const QString& extension) const
could be static indeed but OTOH its main use is within the context of
KoAbstractApplicationController.

> 2. the code which opens the documents (create a kodocument, do canvas magic
> etc), sharing this wouldn't be straightforward as its different in QWidget
> and QML scenarios

Yes, this part should be improved as follows: you show me your code
for QML case, then we can adopt the canvas creation code to address
both use cases.

-- 
regards / pozdrawiam, Jaroslaw Staniek
 http://www.linkedin.com/in/jstaniek
 Kexi & Calligra (kexi-project.org, identi.ca/kexi, calligra-suite.org)
 KDE Software Development Platform on MS Windows (windows.kde.org)
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

Reply via email to