----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101064/#review2510 -----------------------------------------------------------
The comments I made for the first class are valid for all your classes. I think Mek should give it a try to say what is needed as he is the maintainer of tables. tables/ui/CellToolBase.cpp <http://git.reviewboard.kde.org/r/101064/#comment2201> please do not abbreviate the variable names. tables/ui/CellToolBase.cpp <http://git.reviewboard.kde.org/r/101064/#comment2202> Please remove all the blanks at the end of the lines. The are all highlighted by reviewboard in red. tables/ui/SimpleBorderWidget.h <http://git.reviewboard.kde.org/r/101064/#comment2200> You should put your name here as I guess you are not Stefan. tables/ui/SimpleBorderWidget.h <http://git.reviewboard.kde.org/r/101064/#comment2203> I did not find a place where those are used. Please remove if they are not needed tables/ui/SimpleBorderWidget.cpp <http://git.reviewboard.kde.org/r/101064/#comment2204> Are you sure all these are used? tables/ui/SimpleFillWidget.h <http://git.reviewboard.kde.org/r/101064/#comment2205> The function is not used please remove - Thorsten On April 8, 2011, 6:58 p.m., Samuel Buttigieg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101064/ > ----------------------------------------------------------- > > (Updated April 8, 2011, 6:58 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > need feedback on "createOptionWidgets()" mod for calligra tables, thx > > > Diffs > ----- > > tables/ui/CellToolBase.h 1e85233 > tables/ui/CellToolBase.cpp 3557fb1 > tables/ui/SimpleBorderWidget.h PRE-CREATION > tables/ui/SimpleBorderWidget.cpp PRE-CREATION > tables/ui/SimpleFillWidget.h PRE-CREATION > tables/ui/SimpleFillWidget.cpp PRE-CREATION > tables/ui/SimpleMergeWidget.h PRE-CREATION > tables/ui/SimpleMergeWidget.cpp PRE-CREATION > tables/ui/SimpleNumFormatWidget.h PRE-CREATION > tables/ui/SimpleNumFormatWidget.cpp PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/101064/diff > > > Testing > ------- > > the icons work fine, perhaps the fill icon needs a bit more work > > > Screenshots > ----------- > > the modified view > http://git.reviewboard.kde.org/r/101064/s/117/ > > > Thanks, > > Samuel > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
