----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100891/#review2092 -----------------------------------------------------------
Ship it! Nice work. Please ship. If my comments don't make sense please discard them. libs/main/config/KoConfigMiscPage.cpp <http://git.reviewboard.kde.org/r/100891/#comment1739> How about removing the two lines instead of checking it again. I know it checks something different but I think it will not hurt and if I have seen correctly both values should be in sync. libs/main/config/KoConfigMiscPage.cpp <http://git.reviewboard.kde.org/r/100891/#comment1738> How about removing the two line instead of checking it again. - Thorsten On March 20, 2011, 8:49 p.m., Jan Hambrecht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100891/ > ----------------------------------------------------------- > > (Updated March 20, 2011, 8:49 p.m.) > > > Review request for Calligra. > > > Summary > ------- > > Patch provides an alternative way to position shapes when pasting them to the > document. The new way allows shapes to be positioned at the position of the > mouse cursor within the current canvas. Which behaviour is used can be > configured via a shared config page. > > > This addresses bug 129096. > http://bugs.kde.org/show_bug.cgi?id=129096 > > > Diffs > ----- > > karbon/ui/dialogs/KarbonConfigureDialog.cpp 12da4b7 > libs/flake/KoResourceManager.h 6c09d58 > libs/flake/KoResourceManager.cpp 2b4bc24 > libs/flake/KoShapeControllerBase.cpp 4dba9e7 > libs/flake/KoShapePaste.cpp 3cb5d58 > libs/kopageapp/dialogs/KoPAConfigureDialog.cpp abd024b > libs/main/config/KoConfigMiscPage.h f49acc3 > libs/main/config/KoConfigMiscPage.cpp 8c1375c > > Diff: http://git.reviewboard.kde.org/r/100891/diff > > > Testing > ------- > > Yes, works like expected. > > > Thanks, > > Jan > >
_______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel
