The GitHub Actions job "Nightly (beta)" on flink.git/release-1.20 has failed.
Run started by GitHub user github-actions[bot] (triggered by 
github-actions[bot]).

Head commit for run:
69542eceb7eaa475dc566fda3ee03d2fc720abb2 / Rui Fan <[email protected]>
[BP-1.20][FLINK-41280][table] Fix CAST of a TIMESTAMP before 1970 to DATE, TIME 
and a lower precision (#29775)

* [FLINK-41280][table] Fix CAST of a TIMESTAMP before 1970 to DATE, TIME and a 
lower precision

Two spots divided the epoch milliseconds with /, which rounds toward zero, so a 
TIMESTAMP before 1970 moved toward 1970: TimestampToDateCastRule for DATE, and 
DateTimeUtils.zeroLastDigits, which truncate() uses for a TIMESTAMP or 
TIMESTAMP_LTZ precision of 3 or less. Use floor division in both. The other 
caller of zeroLastDigits passes the nano-of-millisecond, which is never 
negative, so floor and truncation agree for it.

On master the TIME conversion lives in 
DateTimeUtils.timestampWithoutLocalZoneToTime, which does not exist on 
release-1.20, so that hunk is dropped here. The TIME conversion on release-1.20 
is fixed in TimestampToTimeCastRule by the following commit.

(cherry picked from commit 0196674040113fa18b8731e17817bbb8f0db8732)

* [FLINK-41280][table] Fix CAST of a TIMESTAMP before 1970 to TIME in 
TimestampToTimeCastRule

On release-1.20 the TIMESTAMP to TIME conversion is generated by 
TimestampToTimeCastRule, which took the millis of day with %. The remainder is 
negative for a TIMESTAMP before 1970, so the TIME was wrong. Use Math.floorMod 
instead, as master does in DateTimeUtils.timestampWithoutLocalZoneToTime.

---------

Co-authored-by: Ramin Gharib <[email protected]>

Report URL: https://github.com/apache/flink/actions/runs/42943024885

With regards,
GitHub Actions via GitBox

Reply via email to