The GitHub Actions job "Docs 404 check (beta)" on 
flink.git/FLINK-XXXXX-group-by-ordinal has failed.
Run started by GitHub user tisyabhatia (triggered by tisyabhatia).

Head commit for run:
6777a0152b85c47ec1f76c72b8018cbbc8348135 / Tisya Bhatia <[email protected]>
FLINK-XXXXX: build the validator conformance in FlinkPlannerImpl

GROUP BY ordinal support was enabled by rewriting the SqlValidator.Config
inside FlinkCalciteSqlValidator. Reading the table config there in order to
change the validator's own config puts configuration in two places.

Derive the conformance in FlinkPlannerImpl.createSqlValidator instead, where
the rest of the validator config is already assembled. 
checkGroupByOrdinalInRange
stays in the validator, since it reads getConformance() rather than the table
config.

Add view tests for the config-flip hazard in both directions: a view created
with ordinals enabled must keep its meaning when the option is later disabled,
and a view created with the option off must not be re-read positionally when it
is turned on.

Co-Authored-By: Claude Opus 5 <[email protected]>

Report URL: https://github.com/apache/flink/actions/runs/31838643648

With regards,
GitHub Actions via GitBox

Reply via email to