The GitHub Actions job "Flink CI (beta)" on flink.git/master has succeeded.
Run started by GitHub user AHeise (triggered by AHeise).

Head commit for run:
b53ea1b1c4d5ab0ec882559a4a050d82ae5740e0 / Arvid Heise 
<[email protected]>
[FLINK-40481][table] Fix SHOW CREATE FROM_NOW timestamp direction (#29030)

ShowCreateUtil.extractStartMode adds the interval to now() when
annotating FROM_NOW/RESUME_OR_FROM_NOW in SHOW CREATE output,
producing a future timestamp in the "Evaluated to
FROM_TIMESTAMP(...)" comment instead of the documented past
resolution. Purely a display bug; it does not affect which data is
actually read.

Thread a Clock through extractStartMode and through a package-private
overload of buildShowCreateMaterializedTableRow (the public API keeps
its existing signatures and hardcodes Clock.systemUTC()), switch to
now(clock).minus(amount), and normalize the clock to UTC before
reading its wall-clock time so a clock in a non-UTC zone can never be
silently mislabeled by the subsequent toInstant(ZoneOffset.UTC).

ShowCreateUtilTest previously normalized the evaluated timestamp in
both the actual and expected strings via regex before comparing,
since it relied on the wall clock and the exact value couldn't be
known in advance. That normalization erased the value being tested,
so it could never have caught a sign error. Inject FIXED_CLOCK into
the parameterized materialized-table test instead and assert the
literal expected string with no normalization; that case already
covers the sign fix, so the only additional unit test kept is one
proving a non-UTC clock zone can't leak into the display.

Co-authored-by: Arvid Heise <[email protected]>

Report URL: https://github.com/apache/flink/actions/runs/33184490774

With regards,
GitHub Actions via GitBox

Reply via email to