The GitHub Actions job "Flink Kubernetes Operator CI" on 
flink-kubernetes-operator.git/FLINK-40246-logback-slf4j2 has failed.
Run started by GitHub user spuru9 (triggered by rmetzger).

Head commit for run:
eb5e100273838b030a58da6a22117d513d543987 / Purushottam Sinha 
<[email protected]>
[FLINK-40246] Pin slf4j-api and prune Flink's SLF4J 1.7 binding

Flink brings slf4j-api 1.7.36 in transitively, and without a
dependencyManagement pin four modules resolve it rather than 2.0.18:
flink-kubernetes-standalone, flink-kubernetes-operator-api,
flink-autoscaler and flink-autoscaler-plugin-jdbc.

The first two then pair 1.7.36 with the 2.x-only log4j-slf4j2-impl. SLF4J
does not fail on a binding/API mismatch: it installs a NOP logger and
discards every log line, so their test output was silently dead. The other
two silently stayed on the complete 1.7 stack, because
flink-test-utils-junit supplies the matching 1.7 binding - which is why the
migration appeared to have succeeded there.

Excluding Flink's log4j-slf4j-impl belongs to the same change rather than
being cleanup: once the pin moves those modules to 2.0.18, the 1.7 binding
inherited from the Flink test utils would be the only one left, flipping
them from working-on-1.7 to NOP.

The shipped image was not affected. flink-kubernetes-operator declares
slf4j-api directly, so the shaded jar always bundled 2.0.18, and the other
modules' classes are caller-side compatible at runtime.

- pin slf4j-api in dependencyManagement
- exclude Flink's log4j-slf4j-impl where flink-test-utils(-junit) puts it on
  a test classpath, and declare log4j-slf4j2-impl there instead
- test_logback_logging.sh: fail on the NOP fallback ("No SLF4J providers
  were found", "Failed to load class StaticLoggerBinder") and match SLF4J
  2.x's "providers" wording alongside 1.7.x's "bindings"

All 14 reactor modules now resolve slf4j-api 2.0.18, and none resolves the
1.7 binding.

Report URL: 
https://github.com/apache/flink-kubernetes-operator/actions/runs/31406205575

With regards,
GitHub Actions via GitBox

Reply via email to