The GitHub Actions job "Flink Kubernetes Operator CI" on 
flink-kubernetes-operator.git/FLINK-40164-fix-suspended-lifecycle-state has 
succeeded.
Run started by GitHub user milindl (triggered by gyfora).

Head commit for run:
487452eb63c930b92f046ed4bfb3e7b385218237 / Milind L <[email protected]>
[FLINK-40164] Complete the suspend when the cancellation is observed

Suspending a job through an asynchronous cancellation left the resource 
reporting the UPGRADING lifecycle state forever. An example that reproduces 
this exists in the ticket.

I experienced it with FlinkSessionJobs (stateless or last-state upgrade mode), 
but even FlinkDeployments in application mode will suffer this (if 
`kubernetes.operator.job.upgrade.last-state.job-cancel.enabled` and 
`upgradeMode` is `last-state` for example).

Savepoint upgrades complete synchronously and are not affected.

To solve: In the observer, after marking resource suspended, we check if it was 
a user has set the desired state of the job to SUSPENDED and whether it's 
UPGRADING, and if so, mark the spec as stable and set 
`ReconciliationState.DEPLOYED`.

Report URL: 
https://github.com/apache/flink-kubernetes-operator/actions/runs/30805490268

With regards,
GitHub Actions via GitBox

Reply via email to