The GitHub Actions job "Nightly (beta)" on flink.git has failed.
Run started by GitHub user github-actions[bot] (triggered by 
github-actions[bot]).

Head commit for run:
a79a649eaa6ad851078dd1f5630fc3009d0c1cc3 / Arvid Heise <ar...@apache.org>
[FLINK-36287] Disallow UC for inner sink channels

Between sink writer, the committer, and any pre/post commit topology (including 
global committer), we don't send actual payload but just committables. These 
committables must be committed on notifyCheckpointCompleted. However, if a 
barrier overtakes these committables, they may only be read after the RPC call 
has been made leading to violations. In particular, we could even have these 
issues during a final checkpoint.

This commit generalizes the way, we disable UC for broadcast and pointwise 
connections, such that the SinkTransformationTranslator can also disable it for 
other distribution pattern.

This commit also Simplifies committer with UC disabled: Without unaligned 
checkpoints, we receive all committables of a given upstream task before the 
respective barrier. Thus, when the barrier reaches the committer, all 
committables of a specific checkpoint must have been received. Committing 
happens even later on notifyCheckpointComplete.

Added an assertion that verifies that all committables are indeed collected on 
commit. Note that this change also works when we recover a sink with channel 
state as it will only be called on the next (partially aligned) checkpoint.

(cherry picked from commit 9d21878befa72f3c2b8f005c137544e2467d5a5e)

Report URL: https://github.com/apache/flink/actions/runs/11905027154

With regards,
GitHub Actions via GitBox

Reply via email to