On Tue, 14 Apr 2026 16:29:47 GMT, Erik Joelsson <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use CXXFLAGS_gcc / CXXFLAGS_clang > > make/modules/java.desktop/lib/ClientLibraries.gmk line 398: > >> 396: AccelGlyphCache.c, \ >> 397: CFLAGS := $(LIBFONTMANAGER_CFLAGS), \ >> 398: CXXFLAGS := $(LIBFONTMANAGER_CFLAGS) $(LIBFONTMANAGER_CXXFLAGS), \ > > I think we would prefer setting `CXXFLAGS_gcc := -fno-rtti -fno-exceptions` > and `CXXFLAGS_clang := -fno-rtti -fno-exceptions` respectively as parameters > here. It's repeating the options, which is unfortunate, but I think it's > easier to read. I changed the makefile. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30701#discussion_r3085446563
