On Fri, 10 Apr 2026 09:13:32 GMT, Kevin Walls <[email protected]> wrote:
>> Ivan Bereziuk has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains eight additional >> commits since the last revision: >> >> - Merge branch 'master' into 8357439_bash_autocomplete_for_jcmd >> - copy the autocompletion script to the jdk image >> - move script in bash-completion/ folder and remove extention >> - moved the script from man to conf folder >> - declare functions consistently >> - more clenup >> - copyright header. minor cleanup >> - 8357439: add bash autocompletion for jcmd > > src/jdk.jcmd/share/conf/bash-completion/jcmd line 1: > >> 1: #!/usr/bin/env bash > > Needed? > On my system, I see hundreds of files in > /usr/share/bash-completion/completions and 2 with this line, so it might be > there by mistake. Are the instructions to "source" this file, not run it > directly? > [the "#!/usr/bin/env bash" comment] might be there by mistake No, I thought it's good to declare that Bash is target shell for this script. We mention word "[Bb]ash" few time more down the file. I should be fine to remove the comment on top. I'll do that. > Are the instructions to "source" this file, not run it directly? Yes, source it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30606#discussion_r3063353381
