On Wed, 8 Apr 2026 12:00:05 GMT, Kevin Walls <[email protected]> wrote:
>>> Is this "We can use the caller frame if it is a signal trampoline." ? >> >> Yes. >> Signal trampoline is special frame, so we can set sender PC/SP/FP straightly >> without DWARF. >> >>> Looks like we do mean to have this check twice here in LinuxAARCH64CFrame. >> >> As I commented, vdso.so on AArch64 Linux might not have `.eh_frame`, then >> DWARF parser would fail. Thus I added signal trampoline check in L160. > > Thanks. > I was thinking if we should make them the same but yes we expect eh_frame on > x64 as I understand, and not on aarch64, and this should be reliable. > > These sender methods are similar so it's good to clarify why they are > different. > I understand this comment now, I thought it was more general: > // DWARF processing might be fail because vdso.so does not have .eh_frame . > > Could it be more specific like: > // DWARF processing might fail because vdso.so .eh_frame is not required on > aarch64 > > (not "be fail") > > Can you make all 3 comments say "We can use the caller frame.." and then I > think you should integrate if no other problems! Thanks a lot! I updated comments in new commit. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29731#discussion_r3051488512
