On Tue, 7 Apr 2026 16:19:52 GMT, Alan Bateman <[email protected]> wrote:

> I wonder if we can remove the `@SuppressWarnings` from this method. SM was 
> not deprecated in JDK 8 so `@SuppressWarnings` is not need for that 
> compilation.

Yes certainly that's a better fix in principle, but trying to do that for this 
and all the hundreds of other cases like it over the entire JDK within this PR 
is unmanageable because new ones are being added all the time.

So... the plan is for there to be two steps: disable the fire alarms at the 
building level first (i.e., the whole module or whatever via 
`-Xlint:-suppression` in make files), then later go back and re-enable them one 
building at a time, while simultaneously putting out all the fires in that 
particular building (i.e., by removing the unnecessary `@SuppressWarning`s).

See [this 
comment](https://github.com/openjdk/jdk/pull/25167#issuecomment-3300177821) for 
a description of my earlier failed attempt to do it the other way around.

And thanks for taking a look by the way.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25167#discussion_r3048081491

Reply via email to