On Thu, 2 Apr 2026 15:28:27 GMT, Erik Joelsson <[email protected]> wrote:
>> Vladimir Yaroslavskiy has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8266431: Dual-Pivot Quicksort improvements >> >> * Moved the scripts out to make/modules/java.base/gensrc directory > > I don't think `make/modules/java.base/gensrc/` is the correct location for > the template and generator scripts. Are these generators meant to be run at > each build, or as a one time run to produce the code that is then committed? > If the former, we need makefile changes for handling the code generation. In > any case, the .java.template files belong in the src tree, not the make tree, > and I would argue that if the scripts are used at commit time, rather than at > build time, they also belong in the src tree. Hi @erikj79, Thank you to point to the location! Generators are to be run one time manually to produce the code that is then committed. I will move generators to src folder. Do you agree? @liach please confirm also. ------------- PR Comment: https://git.openjdk.org/jdk/pull/27411#issuecomment-4180509544
