On Tue, 31 Mar 2026 10:07:07 GMT, Andrew Dinn <[email protected]> wrote:
> Why introduce this as part of the current change?
Because I want to use ZR as an input.
> Also, why is Rm installed using zrf but Rn and Rd installed using rf? They
> are all documented as Xm/Wm etc in the ARM ARM.
They are, but when I started all of this I didn't use `zrf`/`srf` in an
instruction pattern until I tested it. That way, if I saw `zrf`/`srf` it was an
indication that a pattern had been tested. I knew that if I had to do hundreds
of instruction patterns I was sure to mess some of them up.
> src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp line 1478:
>
>> 1476: ciProfileData* data = nullptr;
>> 1477:
>> 1478: __ block_comment("void
>> LIR_Assembler::emit_opTypeCheck(LIR_OpTypeCheck* op) {");
>
> What's the value of providing this comment with a '{' but no matching '}'?
I should delete this.
> src/hotspot/share/c1/c1_LIRGenerator.cpp line 971:
>
>> 969: LIR_Opr tmp = new_register(T_INT);
>> 970: LIR_Opr step = LIR_OprFact::intConst(DataLayout::counter_increment);
>> 971: LIR_Opr dummy = LIR_OprFact::intConst(0);
>
> What is dummy for?
Eh, I thought I'd caught all of those. Will delete.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3023470216
PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3023499510
PR Review Comment: https://git.openjdk.org/jdk/pull/28541#discussion_r3023507309
