Merge request https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/843 was reviewed by Joel Sherrill
-- Joel Sherrill started a new discussion on cpukit/libmisc/cpuuse/cpuuse_backtrace.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/843#note_136479 > +) > +{ > + if (thread == NULL) { Can this happen in a non-debug build? If for safety, use the RTEMS _Assert() which is turned on for debug. Otherwise, this becomes untestable code. -- Joel Sherrill started a new discussion on cpukit/libmisc/cpuuse/cpuusagemax.c: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/843#note_136480 > + * @brief Extract program counter from context for supported architectures > + */ > +static uintptr_t RtemsContextToPC(Context_Control *context) I think this file should be split into multiple per architecture files like libdl and libdebugger are done. Otherwise, this is going to become huge and unwieldy. -- View it on GitLab: https://gitlab.rtems.org/rtems/rtos/rtems/-/merge_requests/843 You're receiving this email because of your account on gitlab.rtems.org.
_______________________________________________ bugs mailing list [email protected] http://lists.rtems.org/mailman/listinfo/bugs
