Joel Sherrill commented on a discussion: 
https://gitlab.rtems.org/rtems/prequal/rtems-central/-/merge_requests/12#note_134889


Thanks for implying my time is being wasted.

Fixing warnings and being able to turn on -Werror is a conscious effort to 
improve code quality and catch issues in newly submitted code before it gets to 
us. 

I saved this summary count from September 3:

>       1 -Wexpansion-to-defined
>       3 -Wcalloc-transposed-args
>       3 -Wempty-body
>       4 -Wabsolute-value
>       4 -Wshift-negative-value
>       7 -Wenum-conversion
>       8 -Wignored-qualifiers
>      13 -Wclobbered
>      23 -Wcast-function-type
>      32 -Wold-style-declaration
>      66 -Wimplicit-fallthrough=
>      70 -Wtype-limits
>     139 -Wmissing-field-initializers
>     273 -Wunterminated-string-initialization
>     842 -Wsign-compare
>    3679 -Wunused-parameter

Most of those warning classes have been eliminated. I expect the remaining to 
be harder and more likely to be real issues. Currently, I am working on 
_-Wmissing-field-initializers_ but have disabled the following until me or 
someone else can look at them. I suspect most of these are going to be fixes 
that are specific to the code cited rather than application of a pattern.

+  - -Wno-cast-function-type
+  - -Wno-enum-conversion
+  - -Wno-shift-negative-value
+  - -Wno-type-limits

Along the way of fixing the warnings, about 30 Coverity issues have 
disappeared. This is important and fixing issues, use of undefined code 
sequence, etc.. 

And this will leave us in a good position for -Werror to catch questionable 
submissions.

-- 
View it on GitLab: 
https://gitlab.rtems.org/rtems/prequal/rtems-central/-/merge_requests/12#note_134889
You're receiving this email because of your account on gitlab.rtems.org.


_______________________________________________
bugs mailing list
[email protected]
http://lists.rtems.org/mailman/listinfo/bugs

Reply via email to